[PATCH] D73615: [clangd] Get rid of delayed template parsing

Kadir Cetinkaya via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jan 29 03:07:21 PST 2020


kadircet created this revision.
kadircet added a reviewer: sammccall.
Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov.
Herald added a project: clang.

No need to pass fno-delayed-template-parsing as the opposite flag is
only passed to cc1 when abi is set to msvc. Sending as a follow-up to D73613 <https://reviews.llvm.org/D73613> to
keep changes in the release branch minimal.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D73615

Files:
  clang-tools-extra/clangd/unittests/HoverTests.cpp


Index: clang-tools-extra/clangd/unittests/HoverTests.cpp
===================================================================
--- clang-tools-extra/clangd/unittests/HoverTests.cpp
+++ clang-tools-extra/clangd/unittests/HoverTests.cpp
@@ -580,9 +580,6 @@
     Annotations T(Case.Code);
     TestTU TU = TestTU::withCode(T.code());
     TU.ExtraArgs.push_back("-std=c++17");
-    // FIXME: This is no longer necessary, as the default behavior is no delayed
-    // parsing in the triplet below.
-    TU.ExtraArgs.push_back("-fno-delayed-template-parsing");
     // Types might be different depending on the target triplet, we chose a
     // fixed one to make sure tests passes on different platform.
     TU.ExtraArgs.push_back("--target=x86_64-pc-linux-gnu");


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D73615.241087.patch
Type: text/x-patch
Size: 759 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20200129/20d48408/attachment.bin>


More information about the cfe-commits mailing list