[PATCH] D73613: [clangd][Hover] Make tests hermetic by setting target triplet

[Sam McCall via Phabricator via cfe-commits]

sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang-tools-extra/clangd/unittests/HoverTests.cpp:583
     TU.ExtraArgs.push_back("-std=c++17");
     TU.ExtraArgs.push_back("-fno-delayed-template-parsing");
+    // Types might be different depending on the target triplet, we chose a
----------------
Is this redundant now? I think the default value here comes from the triple.
(Maybe want to leave it so we have the most-trivial-possible-change for the branch, but add a FIXME)


================
Comment at: clang-tools-extra/clangd/unittests/HoverTests.cpp:586
+    // fixed one to make sure tests passes on different platform.
+    TU.ExtraArgs.push_back("--target=x86_64-pc-linux-gnu");
     auto AST = TU.build();
----------------
this is a good fix for the branch.
For trunk, should we do this in TestTU (i.e. for everything?)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73613/new/

https://reviews.llvm.org/D73613