[PATCH] D73547: [Analyzer] Split container modeling from iterator modeling

Balogh, Ádám via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jan 28 22:34:35 PST 2020


baloghadamsoftware added a comment.

In D73547#1845339 <https://reviews.llvm.org/D73547#1845339>, @NoQ wrote:

> This patch is simply moving code around, right? If so, why did tests need to be removed?


All of the container begin- and end-tests were removed from `iterator-modeling.cpp` and moved to `container-modelin.cpp` except those which do not make sense at the moment: container ends are not touched in modeling `insert()` and `erase()` methods. This will probably change in the future but I cannot even add `FIXME` tests because I do not know every detail yet. If you which, I can add these tests back to `container-modeling.cpp` as they were in `iterator-modeling.cpp`.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73547/new/

https://reviews.llvm.org/D73547





More information about the cfe-commits mailing list