[PATCH] D73360: [OpenCL] Restrict address space conversions in nested pointers

[John McCall via Phabricator via cfe-commits]

rjmccall requested changes to this revision.
rjmccall added inline comments.
This revision now requires changes to proceed.


================
Comment at: clang/test/Misc/warning-flags.c:41
 CHECK-NEXT:   warn_asm_label_on_auto_decl
+CHECK-NEXT:   warn_bad_cxx_cast_nested_pointer_addr_space
 CHECK-NEXT:   warn_c_kext
----------------
Please give this warning  a warning group rather than changing this test.


================
Comment at: clang/test/SemaOpenCL/address-spaces-conversions-cl2.0.cl:521
+#else
+// expected-error at -5 {{assigning to '__generic int *__generic *' from incompatible type '__local int *__local *__private'}}
 #endif
----------------
Can we specialize the diagnostic here so that we get the good diagnostic in both language modes?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73360/new/

https://reviews.llvm.org/D73360