[PATCH] D73457: [Clang] Warn about 'z' printf modifier in old MSVC.

Nico Weber via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jan 28 06:31:51 PST 2020


thakis added a comment.

This breaks tests on Windows: http://45.33.8.238/win/6812/step_7.txt

Since we auto-detect -fmsc-version if it's not explicitly installed and since this warning is on by default, it makes the test suite depend on the environment a good bit. Given how old 2015 is by now, I'm not sure this complexity and subtlety is worth the benefit?

In any case, I'll revert this for now to heal the bots.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73457/new/

https://reviews.llvm.org/D73457





More information about the cfe-commits mailing list