[PATCH] D73520: [analyzer] BugReporterVisitors: Refactor and documentation

[Csaba Dabis via Phabricator via cfe-commits]

Charusso marked 2 inline comments as done.
Charusso added inline comments.


================
Comment at: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporterVisitors.h:195
+
+  static const char *getTag() { return "FindLastStore"; }
+
----------------
I have made every tag a small-string.


================
Comment at: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporterVisitors.h:203
+    ID.AddBoolean(EnableNullFPSuppression);
+  }
 };
----------------
I have put every Profile into the header, so it is easier to see which members are not added to the Profile. I think the root cause of https://bugs.llvm.org/show_bug.cgi?id=42938 could be some issue with differentiating between visitors.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73520/new/

https://reviews.llvm.org/D73520