[PATCH] D73319: Add extension 'gnu_asm_goto_with_outputs'

[Bill Wendling via Phabricator via cfe-commits]

void marked an inline comment as done.
void added a comment.

In D73319#1843129 <https://reviews.llvm.org/D73319#1843129>, @nickdesaulniers wrote:

> In D73319#1842951 <https://reviews.llvm.org/D73319#1842951>, @void wrote:
>
> > In D73319#1842900 <https://reviews.llvm.org/D73319#1842900>, @nickdesaulniers wrote:
> >
> > > Great idea; thanks for the patch! Needs documentation. :)
> >
> >
> > I can't find a place for documentation of extensions, at least not the names of extensions like `gnu_asm`.
>
>
> How about https://clang.llvm.org/docs/LanguageExtensions.html#checks-for-standard-language-features ? Then we can add both `gnu_asm` and `gnu_asm_goto_with_outputs`.


That looks like it's features specific to various versions of C/C++. There were other examples like https://clang.llvm.org/docs/LanguageExtensions.html#blocks.



================
Comment at: clang/test/Parser/asm-goto.c:9
+#error Extension 'gnu_asm_goto_with_outputs' should be available by default
+#endif
 
----------------
nickdesaulniers wrote:
> ah, sorry, maybe a test that makes use of `asm goto` + output constraints? Maybe if you base your patch on top of the others in the series that implement the feature?
There's one below in `zoo`. The order of these patches is a bit wonky because the front-end patch, which has more tests for AGWO, should go in before this one.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73319/new/

https://reviews.llvm.org/D73319