[PATCH] D73261: [dwarf5] Support DebugInfo for constexpr for C++ variables and functions

[David Blaikie via Phabricator via cfe-commits]

dblaikie added a comment.

General question: What purpose do you (or anyone else - @probinson, @aprantl) have for this attribute? I'd like to encourage the idea that we don't need to implement every feature DWARF provides if there's no planned use for it - things can/should be implemented as-motivated so we don't end up with weird features/implementations/etc that are essentially untested/unused.



================
Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:3406
       getOrCreateFunctionType(GD.getDecl(), FnType, Unit), 0, Flags, SPFlags,
-      TParamsArray.get(), getFunctionDeclaration(FD));
+      false, TParamsArray.get(), getFunctionDeclaration(FD));
   const FunctionDecl *CanonDecl = FD->getCanonicalDecl();
----------------
Any reason isConstexpr shouldn't be specified here too?


================
Comment at: clang/test/CodeGenCXX/constExpr.cpp:9
+// CHECK: DIGlobalVariable(name: "bar", {{.*}} constExpr: true)
+// CHECK: DISubprogram(name: "main", {{.*}} constExpr: false{{.*}}
+// CHECK: DILocalVariable(name: "baz", {{.*}} constExpr: true)
----------------
do these {{.*}} on the end of the lines provide any particular value? 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73261/new/

https://reviews.llvm.org/D73261