[PATCH] D73439: [ASTMatchers] Add cxxNoexceptExpr AST matcher

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jan 27 07:25:42 PST 2020


aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

LGTM aside from some minor nits.



================
Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:1831
+/// \code
+///   void nothrow() noexcpet;
+///   void throws();
----------------
typo -- `noexcept`


================
Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:1835
+///   bool b = noexcept(throws())
+/// \endcode
+/// cxxNoexceptExpr()
----------------
Can you also add this as an example:
```
void func() noexcept(noexcept(1 + 1));
```
to make it clear that this matches `noexcept(1 + 1)` but not `noexcept(noexcept(...))`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73439/new/

https://reviews.llvm.org/D73439





More information about the cfe-commits mailing list