[PATCH] D73300: [clang-tidy] Add library for clang-tidy main function

Nico Weber via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jan 27 06:49:05 PST 2020


thakis added inline comments.


================
Comment at: clang-tools-extra/clang-tidy/tool/CMakeLists.txt:22
+  clangToolingCore
+  )
+
----------------
Normally we have a single cmake target per CMakeLists.txt. Maybe the library could be in clang-tidy/lib and clang-tidy/tool could use it? Then you wouldn't need the LLVM_OPTIONAL_SOURCES hack and it'd be all a bit nicer.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73300/new/

https://reviews.llvm.org/D73300





More information about the cfe-commits mailing list