[PATCH] D73418: [WPD] Emit vcall_visibility metadata for MicrosoftCXXABI

Teresa Johnson via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Jan 25 13:35:09 PST 2020


tejohnson added a comment.

I fixed the test matching as I found that the names generated for the anonymous namespace comdats depend on the module identifier in some way. I changed the matching to look at the struct type embedded in the initializer, which is also more intuitive. I also moved the new MS checks to be alongside the companion Itanium checks. And I added comments noting that MSVC gets DSO (hidden) visibility by default.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73418/new/

https://reviews.llvm.org/D73418





More information about the cfe-commits mailing list