[PATCH] D73413: [clang-tidy] Add check to detect external definitions with no header declaration

[Eugene Zelenko via Phabricator via cfe-commits]

Eugene.Zelenko added inline comments.


================
Comment at: clang-tools-extra/clang-tidy/misc/MissingHeaderFileDeclarationCheck.cpp:14
+#include "llvm/ADT/Optional.h"
+#include "llvm/ADT/StringSwitch.h"
+#include <type_traits>
----------------
Please also include StringRef.


================
Comment at: clang-tools-extra/test/clang-tidy/checkers/Inputs/misc-missing-header-file-declaration/wrong_header.h:8
+#endif
\ No newline at end of file

----------------
Please add newline.


================
Comment at: clang-tools-extra/test/clang-tidy/checkers/misc-missing-header-file-declaration-any-header.cpp:17
+// CHECK-MESSAGES: :[[@LINE-1]]:6: warning: Variable 'Failure' is defined with external linkage
\ No newline at end of file

----------------
Please add newline.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73413/new/

https://reviews.llvm.org/D73413