[PATCH] D73388: NFC: Implement AST node skipping in ParentMapContext
Richard Smith - zygoloid via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Jan 24 19:00:51 PST 2020
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
This seems reasonable to me.
If you want to unify something about this and the `Ignore*` functions in `Expr`, maybe we could add a "classify" mechanism, so you could ask "what kind of node is this?" and get back an enumerated value that indicates whether it's semantic / syntactic / whatever. Then we could implement both this and the downward-skipping in terms of that.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73388/new/
https://reviews.llvm.org/D73388
More information about the cfe-commits
mailing list