[PATCH] D73282: Fix debug-info generation for block invocations so that we set the LinkageName instead of the Name
Adrian Prantl via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Jan 24 16:36:14 PST 2020
aprantl added inline comments.
================
Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:3659
// Use llvm function name.
- Name = Fn->getName();
+ if (Fn->getName().startswith("___Z"))
+ LinkageName = Fn->getName();
----------------
Could you please add a comment that Clang Blocks are generated as raw llvm::Functions but do have a mangled name and that is handling this case? Otherwise this would look suspicious.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73282/new/
https://reviews.llvm.org/D73282
More information about the cfe-commits
mailing list