[PATCH] D73028: Extract ExprTraversal class from Expr

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman added a comment.

This looks like it's an NFC patch where the only change is to hoist this functionality out into its own interface. Is that correct? If so, can you please be sure to add NFC to the commit log?



================
Comment at: clang/include/clang/AST/ExprTraversal.h:9
+//
+//  This file defines the ExprTraversal class.
+//
----------------
Some comments explaining the purpose of the file would be appreciated.


================
Comment at: clang/include/clang/AST/ExprTraversal.h:21
+
+struct ExprTraversal {
+  static Expr *DescendIgnoreImpCasts(Expr *E);
----------------
Any particular reason why this is a `struct` rather than a `namespace` given that there's no state?


================
Comment at: clang/include/clang/AST/ExprTraversal.h:22
+struct ExprTraversal {
+  static Expr *DescendIgnoreImpCasts(Expr *E);
+  static Expr *DescendIgnoreCasts(Expr *E);
----------------
Should we be adding some documentation comments for these APIs?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73028/new/

https://reviews.llvm.org/D73028