[PATCH] D73270: [clang-tidy] Fix false positive in bugprone-infinite-loop

Fri Jan 24 08:59:02 PST 2020

njames93 added a comment.

In D73270#1838956 <https://reviews.llvm.org/D73270#1838956>, @gribozavr2 wrote:

> In D73270#1838883 <https://reviews.llvm.org/D73270#1838883>, @njames93 wrote:
>
> > May not be one for this patch, but how does this check handle volatile loop variables and cases where modification isn't visible in the context e.g.
>
>
> Should be OK, see "if (Var->getType().isVolatileQualified())" in the implementation. Feel free to submit another patch with more tests!

Ahh I see, it also handles calls which take the var as a reference or pointer, test cases would be good but doesn't need to be in here

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73270/new/

https://reviews.llvm.org/D73270