[PATCH] D73336: [clangd][Hover] Change arrow in return type back to →
Kadir Cetinkaya via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Jan 24 04:08:12 PST 2020
This revision was automatically updated to reflect the committed changes.
Closed by commit rG1b996faa1575: [clangd][Hover] Change arrow in return type back to → (authored by kadircet).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73336/new/
https://reviews.llvm.org/D73336
Files:
clang-tools-extra/clangd/Hover.cpp
clang-tools-extra/clangd/test/hover.test
clang-tools-extra/clangd/unittests/HoverTests.cpp
Index: clang-tools-extra/clangd/unittests/HoverTests.cpp
===================================================================
--- clang-tools-extra/clangd/unittests/HoverTests.cpp
+++ clang-tools-extra/clangd/unittests/HoverTests.cpp
@@ -1744,7 +1744,7 @@
},
R"(function foo
-🡺 ret_type
+→ ret_type
Parameters:
-
- type
Index: clang-tools-extra/clangd/test/hover.test
===================================================================
--- clang-tools-extra/clangd/test/hover.test
+++ clang-tools-extra/clangd/test/hover.test
@@ -9,7 +9,7 @@
# CHECK-NEXT: "result": {
# CHECK-NEXT: "contents": {
# CHECK-NEXT: "kind": "plaintext",
-# CHECK-NEXT: "value": "function foo\n\n🡺 void\n\nvoid foo()"
+# CHECK-NEXT: "value": "function foo\n\n→ void\n\nvoid foo()"
# CHECK-NEXT: },
# CHECK-NEXT: "range": {
# CHECK-NEXT: "end": {
Index: clang-tools-extra/clangd/Hover.cpp
===================================================================
--- clang-tools-extra/clangd/Hover.cpp
+++ clang-tools-extra/clangd/Hover.cpp
@@ -546,11 +546,11 @@
// editor, as they might be long.
if (ReturnType) {
// For functions we display signature in a list form, e.g.:
- // 🡺 `x`
+ // → `x`
// Parameters:
// - `bool param1`
// - `int param2 = 5`
- Output.addParagraph().appendText("🡺").appendCode(*ReturnType);
+ Output.addParagraph().appendText("→").appendCode(*ReturnType);
if (Parameters && !Parameters->empty()) {
Output.addParagraph().appendText("Parameters:");
markup::BulletList &L = Output.addBulletList();
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D73336.240157.patch
Type: text/x-patch
Size: 1639 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20200124/0121dc06/attachment.bin>
More information about the cfe-commits
mailing list