[PATCH] D73320: [WebAssembly] Add reference types target feature

Fri Jan 24 01:51:58 PST 2020

aheejin marked 2 inline comments as done.
aheejin added inline comments.

================
Comment at: llvm/test/CodeGen/WebAssembly/reference-types.ll:4
+; This currently only tests if the command line argument for reference types
+; feature is accepted by llc.
+
----------------
sbc100 wrote:
> Couldn't we also check the that attribute is attached to the dummy function?
It's a good idea if we also check if the target feature also appears in the target features section. But because either setting the attribute in a function or giving the command line attribute argument equally sets the feature in the target features section, I'll test the arg in this file, and test the function attribute in the existing target-features.ll.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73320/new/

https://reviews.llvm.org/D73320