[clang] 52311d0 - [objc_direct] do not add direct properties to the serialization array

[Pierre Habouzit via cfe-commits]

Author: Pierre Habouzit
Date: 2020-01-23T22:39:47-08:00
New Revision: 52311d0483eecd60bdcc39dd3fb134f2412370f6

URL: https://github.com/llvm/llvm-project/commit/52311d0483eecd60bdcc39dd3fb134f2412370f6
DIFF: https://github.com/llvm/llvm-project/commit/52311d0483eecd60bdcc39dd3fb134f2412370f6.diff

LOG: [objc_direct] do not add direct properties to the serialization array

If we do, then the property_list_t length is wrong
and class_getProperty gets very sad.

Signed-off-by: Pierre Habouzit <phabouzit at apple.com>
Radar-Id: rdar://problem/58804805
Differential Revision: https://reviews.llvm.org/D73219

Added: 
    clang/test/CodeGenObjC/direct-properties.m

Modified: 
    clang/lib/CodeGen/CGObjCMac.cpp

Removed: 
    


################################################################################
diff  --git a/clang/lib/CodeGen/CGObjCMac.cpp b/clang/lib/CodeGen/CGObjCMac.cpp
index f36c28a85a68..b36d97357906 100644
--- a/clang/lib/CodeGen/CGObjCMac.cpp
+++ b/clang/lib/CodeGen/CGObjCMac.cpp
@@ -3291,6 +3291,8 @@ llvm::Constant *CGObjCCommonMac::EmitPropertyList(Twine Name,
       for (auto *PD : ClassExt->properties()) {
         if (IsClassProperty != PD->isClassProperty())
           continue;
+        if (PD->isDirectProperty())
+          continue;
         PropertySet.insert(PD->getIdentifier());
         Properties.push_back(PD);
       }
@@ -3302,6 +3304,8 @@ llvm::Constant *CGObjCCommonMac::EmitPropertyList(Twine Name,
     // class extension.
     if (!PropertySet.insert(PD->getIdentifier()).second)
       continue;
+    if (PD->isDirectProperty())
+      continue;
     Properties.push_back(PD);
   }
 
@@ -3327,8 +3331,6 @@ llvm::Constant *CGObjCCommonMac::EmitPropertyList(Twine Name,
   values.addInt(ObjCTypes.IntTy, Properties.size());
   auto propertiesArray = values.beginArray(ObjCTypes.PropertyTy);
   for (auto PD : Properties) {
-    if (PD->isDirectProperty())
-      continue;
     auto property = propertiesArray.beginStruct(ObjCTypes.PropertyTy);
     property.add(GetPropertyName(PD->getIdentifier()));
     property.add(GetPropertyTypeString(PD, Container));

diff  --git a/clang/test/CodeGenObjC/direct-properties.m b/clang/test/CodeGenObjC/direct-properties.m
new file mode 100644
index 000000000000..113ac12f18bf
--- /dev/null
+++ b/clang/test/CodeGenObjC/direct-properties.m
@@ -0,0 +1,23 @@
+// RUN: %clang_cc1 -emit-llvm -fobjc-arc -triple x86_64-apple-darwin10 %s -o - | FileCheck %s
+
+__attribute__((objc_root_class))
+ at interface A
+ at property(direct, readonly) int i;
+ at end
+
+__attribute__((objc_root_class))
+ at interface B
+ at property(direct, readonly) int i;
+ at property(readonly) int j;
+ at end
+
+// CHECK-NOT: @"__OBJC_$_PROP_LIST_A"
+ at implementation A
+ at synthesize i = _i;
+ at end
+
+// CHECK: @"_OBJC_$_PROP_LIST_B" = internal global { i32, i32, [1 x %struct._prop_t] } { i32 16, i32 1
+ at implementation B
+ at synthesize i = _i;
+ at synthesize j = _j;
+ at end