[PATCH] D67537: [clangd] Client-side support for inactive regions

[Nathan Ridge via Phabricator via cfe-commits]

nridge added a comment.

In D67537#1833987 <https://reviews.llvm.org/D67537#1833987>, @hokein wrote:

> there is some significant progress about semantic highlighting on VSCode,  VSCode now provides an experimental semantic token API <https://github.com/microsoft/vscode/wiki/Semantic-Highlighting-Overview>, but no LSP binding yet (is not far away I think). When it is ready, we'd like to switch to that and get rid of our own implementation.


Agreed.

(One potential issue is that vscode themes don't support background styling <https://github.com/microsoft/vscode/issues/3429>. However, that issue has been getting a lot of attention, hopefully it too will be fixed soon.)

I do think there's value in landing this patch in the interim.

> Looking at the API there, it seems like we could make the line-style scope name `meta.disable` clangd specific, and define our own style.

Do you mean naming the scope something like `clangd.meta.disable` to make it clear it's a clangd extension?

(In that case, we might as well make it something more descriptive, like `clangd.preprocessor.inactive`. `meta` doesn't convey much information.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67537/new/

https://reviews.llvm.org/D67537