[PATCH] D72222: [Driver][CodeGen] Add -fpatchable-function-entry=N[,0]

Nick Desaulniers via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 23 12:29:42 PST 2020


nickdesaulniers added a comment.

In D72222#1836687 <https://reviews.llvm.org/D72222#1836687>, @MaskRay wrote:

> (I really dislike how the feature was developed on the GCC side. Yet another Linux-kernel specific GCC option when there are already 4 existing options for the same feature)


Maybe I'm reading too much into it, but please always have respect for the competition, as a representative of the company and LLVM community you represent, as well as my friend.  It should be clear why that's important and why I won't tolerate anything less.  If you still disagree, I'm happy to talk more about it privately.

Can you enumerate the 4 existing options?  If we do already have an existing tool in our toolbox, it would be good to consider their strengths and limitations before building a new tool.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72222/new/

https://reviews.llvm.org/D72222





More information about the cfe-commits mailing list