[PATCH] D67678: PR17164: Change clang's default behavior from -flax-vector-conversions=all to -flax-vector-conversions=integer.

[Steven Wu via Phabricator via cfe-commits]

steven_wu added a subscriber: dexonsmith.
steven_wu added a comment.

In D67678#1834957 <https://reviews.llvm.org/D67678#1834957>, @rsmith wrote:

> In D67678#1834542 <https://reviews.llvm.org/D67678#1834542>, @steven_wu wrote:
>
> > @rsmith This also breaks macOS SDK. Can we revert this as we discuss a less aggressive option?
>
>
> (This was already reverted a couple of days ago.)
>
> Do you have a timeline for how long it would take to fix the MacOS SDK? Is this something we could realistically aim to do in Clang 11 instead? I would really prefer for us to not have different defaults for Darwin versus everywhere else, so if waiting one release cycle is enough, that seems fine.
>
> I'll split out the new flag at least and re-land for Clang 10, while we figure out how to set the default.


I am not sure if we ever have rules about compatibility against old SDKs. The earliest time we can fix SDK is the next major Xcode release, which might not 
@dexonsmith

In D67678#1834957 <https://reviews.llvm.org/D67678#1834957>, @rsmith wrote:

> In D67678#1834542 <https://reviews.llvm.org/D67678#1834542>, @steven_wu wrote:
>
> > @rsmith This also breaks macOS SDK. Can we revert this as we discuss a less aggressive option?
>
>
> (This was already reverted a couple of days ago.)
>
> Do you have a timeline for how long it would take to fix the MacOS SDK? Is this something we could realistically aim to do in Clang 11 instead? I would really prefer for us to not have different defaults for Darwin versus everywhere else, so if waiting one release cycle is enough, that seems fine.
>
> I'll split out the new flag at least and re-land for Clang 10, while we figure out how to set the default.


Thanks @rsmith!

I am also not sure if we have rules about SDK compatibility for releases and I can't say macOS SDK can definitely be fixed before clang 11 release. @dexonsmith @arphaman might have more info.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67678/new/

https://reviews.llvm.org/D67678