[PATCH] D73219: [objc_direct] do not add direct properties to the serialization array

Pierre Habouzit via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 23 08:52:33 PST 2020


MadCoder marked 2 inline comments as done.
MadCoder added inline comments.


================
Comment at: clang/lib/CodeGen/CGObjCMac.cpp:3316-3319
   else if (const ObjCCategoryDecl *CD = dyn_cast<ObjCCategoryDecl>(OCD)) {
     for (const auto *P : CD->protocols())
       PushProtocolProperties(PropertySet, Properties, P, IsClassProperty);
   }
----------------
dexonsmith wrote:
> Do you need similar logic in `PushProtocolProperties`?
no: you can't have anything direct in a Protocol.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73219/new/

https://reviews.llvm.org/D73219





More information about the cfe-commits mailing list