[PATCH] D73098: [clang-tidy] readability-identifier-naming disregards parameters restrictions on main like functions
Nathan James via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Jan 23 03:17:07 PST 2020
njames93 added inline comments.
================
Comment at: clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp:383
+ } else {
+ static llvm::Regex Matcher("(^((W[Mm])|(wm))ain([_A-Z]|$))|([a-z0-9_]W[Mm]"
+ "ain([_A-Z]|$))|(_wmain(_|$))",
----------------
Any thoughts on whether I should detect WMain or just Wmain. WMain looks more pleasing but using CamelCase rules it should likely be Wmain
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73098/new/
https://reviews.llvm.org/D73098
More information about the cfe-commits
mailing list