[PATCH] D73162: [test] Avoid loop-unroll.c test getting confused by fadd in git revision
Russell Gallop via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Jan 23 01:33:56 PST 2020
russell.gallop added a comment.
In D73162#1834379 <https://reviews.llvm.org/D73162#1834379>, @asbirlea wrote:
> Oh, wow! Might I ask you add the same for fmul? We may get a revision like that next time :).
> Thank you!
fmul shouldn't have the same problem as git hashes are only hex characters.
In D73162#1834392 <https://reviews.llvm.org/D73162#1834392>, @fhahn wrote:
> I think we could also just add a single match for something after the generated functions, to limit the scope of CHECK-NOT, e.g add something like `CHECK : !0 =`
Thanks, that's cleaner.
Note that the diff here is a little confused. There are now no changes to the previous check lines.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73162/new/
https://reviews.llvm.org/D73162
More information about the cfe-commits
mailing list