[PATCH] D72829: Implement -fsemantic-interposition

George Rimar via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 23 01:07:16 PST 2020


grimar added inline comments.


================
Comment at: llvm/lib/IR/Module.cpp:558
+bool Module::getSemanticInterposition() const {
+  auto *Val =
+      cast_or_null<ConstantAsMetadata>(getModuleFlag("SemanticInterposition"));
----------------
A minor nit about style:
This probably would be nicer as

```
  if (auto *Val = cast_or_null<ConstantAsMetadata>(
          getModuleFlag("SemanticInterposition")))
    return cast<ConstantInt>(Val->getValue())->getZExtValue();
  return false;
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72829/new/

https://reviews.llvm.org/D72829





More information about the cfe-commits mailing list