[PATCH] D73199: [clangd] Errors in TestTU cause test failures unless suppressed with error-ok.

[Kadir Cetinkaya via Phabricator via cfe-commits]

kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.

LGTM, thanks for the cleanup!



================
Comment at: clang-tools-extra/clangd/unittests/TestTU.cpp:84
+  if (llvm::none_of(Files, [](const auto &KV) {
+        return llvm::StringRef(KV.second).contains("error-ok");
+      })) {
----------------
should we make this more obscure, something like `// TESTTU: error-ok` ?

Even though it sounds implausible, just in case someone spells `error-ok` as part of the test, and silently drops the error :D


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73199/new/

https://reviews.llvm.org/D73199