[PATCH] D72242: Fix crash on value dependent bitfields in if conditions in templates
Elizabeth Andrews via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Jan 22 15:12:25 PST 2020
eandrews added a comment.
In D72242#1820908 <https://reviews.llvm.org/D72242#1820908>, @rnk wrote:
> I think I liked the first version of this patch better. I would say, if the AST after instantiation remains the same as it was before D69950 <https://reviews.llvm.org/D69950>, then the first one seems like the right fix.
Thanks for taking a look Reid. The AST after instantiation (ClassTemplateSpecializationDecl) remains the same. I'll upload the old patch for review again after modifying test to add AST checks @erichkeane do you have any concerns?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72242/new/
https://reviews.llvm.org/D72242
More information about the cfe-commits
mailing list