[PATCH] D73120: [Clang] Alternate fix for "expansion of response files in -Wp after integrated-cc1 change"

Hans Wennborg via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jan 22 11:46:57 PST 2020


hans added inline comments.


================
Comment at: clang/test/Driver/Wp-args.c:27
+
+// RSP: inception
----------------
aganea wrote:
> hans wrote:
> > Why inception? I feel like I'm missing something :)
> Could be anything else :) Because `-rewrite-macros` prints this .c with comments, and then FileCheck looks for that tag in stdout.
Ah, I see.

Do you think it would be possible to do something simpler, like just pass a -D flag and check that it gets set? That would be easier for future readers of the test to understand.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73120/new/

https://reviews.llvm.org/D73120





More information about the cfe-commits mailing list