[PATCH] D73203: [clang-tidy] Prevent a remove only fixit causing a conflict when enclosed by another fixit
Eugene Zelenko via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Jan 22 09:18:25 PST 2020
Eugene.Zelenko added inline comments.
================
Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp:726
+ unsigned ErrorIndex = ErrorAndDiscarded.first;
+ const auto &Discarded = ErrorAndDiscarded.second;
+ if (!Apply[ErrorIndex])
----------------
Please don't use auto unless type is spelled in same statement or iterator.
================
Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp:730
+ tooling::Replacements NewReplacements;
+ const auto &CurReplacements =
+ ErrorFixes[ErrorIndex].second->lookup(FileAndEvents.first);
----------------
Please don't use auto unless type is spelled in same statement or iterator.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73203/new/
https://reviews.llvm.org/D73203
More information about the cfe-commits
mailing list