[PATCH] D72552: [Concepts] Constraint Satisfaction Caching

[Richard Trieu via Phabricator via cfe-commits]

rtrieu added inline comments.


================
Comment at: clang/lib/AST/ASTConcept.cpp:17
 #include "clang/AST/ASTContext.h"
+#include "clang/Sema/SemaConcept.h"
 using namespace clang;
----------------
This causes a circular dependency between AST and Sema.  It looks like you are including this header to get access to some classes, but you should include the direct header instead.  These are the headers for the classes you are using in ConstraintSatisfaction::Profile:

NamedDecl -> clang/AST/Decl.h
TemplateArgument -> clang/AST/TemplateBase.h
ArrayRef -> llvm/ADT/ArrayRef.h
FoldingSetNodeID -> llvm/ADT/FoldingSet.h

Please update the header includes to resolve the circular dependency.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72552/new/

https://reviews.llvm.org/D72552