[PATCH] D71566: New checks for fortified sprintf

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman added a comment.

(There are still some minor whitespace nits to resolve as well.)



================
Comment at: clang/lib/Sema/SemaChecking.cpp:743
+  }
+  assert(UsedSize && "Found a size estimate");
+  if (UsedSize.getValue().ule(ObjectSize))
----------------
I think this assertion can be triggered in the case where no `UsedSize` was specified but then `UsedSizeArg` evaluates to `0`, can't it? Or does something catch that case and diagnose?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71566/new/

https://reviews.llvm.org/D71566