[PATCH] D73128: [OPENMP][NVPTX]Add NVPTX specific definitions for new/delete operators.

Johannes Doerfert via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jan 21 11:46:27 PST 2020


jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.

Some minor comments but other than that, LGTM.

Nit: Clang format the file



================
Comment at: clang/lib/Headers/openmp_wrappers/new:8
+ *===-----------------------------------------------------------------------===
+ */
+
----------------
Nit: The license usually has C++ style comments `//`


================
Comment at: clang/lib/Headers/openmp_wrappers/new:27
+    size = 1;
+  }
+  return ::malloc(size);
----------------
Style: No braces around single statements.  We could even call it unconditionally. 


================
Comment at: clang/lib/Headers/openmp_wrappers/new:43
+    ::free(ptr);
+  }
+}
----------------
Style: No braces around single statements. We could even call it unconditionally. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73128/new/

https://reviews.llvm.org/D73128





More information about the cfe-commits mailing list