[PATCH] D72848: Remove some SVN-specific code.

[Hans Wennborg via Phabricator via cfe-commits]

hans added inline comments.


================
Comment at: clang/lib/Basic/Version.cpp:33
 #else
-  StringRef URL("");
+  return "";
 #endif
----------------
Eugene.Zelenko wrote:
> hans wrote:
> > Eugene.Zelenko wrote:
> > > return {} should be better.
> > Why? I think "" is clearer for a string.
> It's default non-trivial object initialization. Also not need for implicit cast.
I still think

```
return "";
```

is a much clearer way of returning an empty string.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72848/new/

https://reviews.llvm.org/D72848