[PATCH] D73106: [Alignment][NFC] Use Align with CreateMaskedStore

Clement Courbet via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jan 21 07:34:55 PST 2020


courbet added inline comments.


================
Comment at: llvm/lib/Transforms/Instrumentation/MemorySanitizer.cpp:2907
     Value *Addr = I.getArgOperand(1);
-    const MaybeAlign Alignment(
+    const Align Alignment(
         cast<ConstantInt>(I.getArgOperand(2))->getZExtValue());
----------------
I think it's actually OK for this one to be a `MaybeAlign`, e.g. in `ARMTTIImpl::isLegalMaskedLoad`.


================
Comment at: llvm/lib/Transforms/Instrumentation/MemorySanitizer.cpp:2937
     Value *Addr = I.getArgOperand(0);
-    const MaybeAlign Alignment(
+    const Align Alignment(
         cast<ConstantInt>(I.getArgOperand(1))->getZExtValue());
----------------
ditto


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73106/new/

https://reviews.llvm.org/D73106





More information about the cfe-commits mailing list