[PATCH] D44609: [clang-format] New option BeforeLambdaBody to manage lambda line break inside function parameter call (in Allman style)

MyDeveloperDay via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jan 20 23:10:52 PST 2020


MyDeveloperDay added a comment.

I think if you can fix the missing documentation it looks pretty good to go.

I do like the use of the static functions and the extensive test cases.. thank you.



================
Comment at: clang/lib/Format/ContinuationIndenter.cpp:1442
+    // Search for any parameter that is a lambda
+    auto const *nextTok = Current.Next;
+    while (nextTok != nullptr) {
----------------
some people don't like the use of auto if the type isn't obvious,

I think by convention shouldn't this variable be `NextTok`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D44609/new/

https://reviews.llvm.org/D44609





More information about the cfe-commits mailing list