[PATCH] D73060: [Clang] Fix expansion of response files in -Wp after integrated-cc1 change

[Alexandre Ganea via Phabricator via cfe-commits]

aganea created this revision.
aganea added reviewers: hans, thakis, wenlei.
aganea added a project: clang.
Herald added a subscriber: cfe-commits.
aganea edited the summary of this revision.

After rGb4a99a061f517e60985667e39519f60186cbb469 <https://reviews.llvm.org/rGb4a99a061f517e60985667e39519f60186cbb469>, passing a response file such as `-Wp, at a.rsp` wasn't working anymore because .rsp expansion happens inside clang's main() function.

I'm noticing along the way that explicit arguments in `-Wp` are parsed in the driver, whereas arguments inside a response file are parsed in the -cc1 tool. Is that the desired behavior? This was the previous behavior but I'm not sure it's the right behavior.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D73060

Files:
  clang/include/clang/Driver/Driver.h
  clang/lib/Driver/Job.cpp
  clang/test/Driver/Wp-args.c
  clang/tools/driver/driver.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D73060.239169.patch
Type: text/x-patch
Size: 3564 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20200120/9dababe0/attachment-0001.bin>