[clang] 122443a - Compare traversal for memoization before bound nodes container

[Aaron Ballman via cfe-commits]

On Mon, Jan 20, 2020 at 7:56 AM Stephen Kelly <steveire at gmail.com> wrote:
>
>
> On 20/01/2020 12:42, Aaron Ballman wrote:
> > On Mon, Jan 20, 2020 at 6:20 AM Stephen Kelly via cfe-commits
> > <cfe-commits at lists.llvm.org> wrote:
> >>
> >> Author: Stephen Kelly
> >> Date: 2020-01-20T11:20:04Z
> >> New Revision: 122443a950521c5d99a0d0479daf57fbd1de2ac2
> >>
> >> URL: https://github.com/llvm/llvm-project/commit/122443a950521c5d99a0d0479daf57fbd1de2ac2
> >> DIFF: https://github.com/llvm/llvm-project/commit/122443a950521c5d99a0d0479daf57fbd1de2ac2.diff
> >>
> >> LOG: Compare traversal for memoization before bound nodes container
> > Is this change missing test cases, or was there existing coverage that
> > was broken which this change is fixing?
>
>
> Sorry, I should have labelled it NFC.
>
> There's no missing test cases or brokenness. This change is made on the
> basis that comparing the enum is cheaper than comparing the container of
> bound nodes.

Ah, okay, that makes plenty of sense. Thank you for clarifying that it
was NFC (change LGTM)!

~Aaron

>
> Thanks,
>
> Stephen.
>
>