[PATCH] D72274: [libTooling] Fix bug in Stencil handling of macro ranges

Dmitri Gribenko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jan 17 07:09:02 PST 2020


gribozavr2 added a comment.

The only functional change that I see in this patch is in `clang/lib/Tooling/Transformer/Stencil.cpp`. However, I don't understand how that change in the (deprecated) selection() stencil can affect other stencils.



================
Comment at: clang/unittests/Tooling/StencilTest.cpp:375
+  double foo(double d);
+  foo(MACRO);)cpp";
+
----------------
"foo(MACRO);" will fail parsing at the top level, it should be within a function, I think.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72274/new/

https://reviews.llvm.org/D72274





More information about the cfe-commits mailing list