[PATCH] D72827: clang-format: [JS] Handle keyword-named methods.

Martin Probst via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jan 17 01:09:37 PST 2020


mprobst added a comment.

In D72827#1823895 <https://reviews.llvm.org/D72827#1823895>, @krasimir wrote:

> How about `if` and `try`? Is there a list somewhere for all such valid identifiers?


This is a bit annoying - generally speaking, we should parse all keywords in declaration locations as simple names. However `UnwrappedLineParser` isn't really structured to support that, nor is it precise enough to reliably detect these situations :-/ So I think the best we can do is incrementally detect these issues and fix as they come up.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72827/new/

https://reviews.llvm.org/D72827





More information about the cfe-commits mailing list