[clang-tools-extra] 4df94d5 - Revert "[clangd][test] Disable a particular testcase in FindExplicitReferencesTest when LLVM_ENABLE_EXPENSIVE_CHECKS"

Kadir Cetinkaya via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 16 23:55:30 PST 2020


Author: Kadir Cetinkaya
Date: 2020-01-17T08:51:13+01:00
New Revision: 4df94d5b513c20842f5eeeb1e0d059bfa6741d91

URL: https://github.com/llvm/llvm-project/commit/4df94d5b513c20842f5eeeb1e0d059bfa6741d91
DIFF: https://github.com/llvm/llvm-project/commit/4df94d5b513c20842f5eeeb1e0d059bfa6741d91.diff

LOG: Revert "[clangd][test] Disable a particular testcase in FindExplicitReferencesTest when LLVM_ENABLE_EXPENSIVE_CHECKS"

This reverts commit 42b3c38903c9c80e129ce678db7f522967e91eeb.

Should've been fixed by d54d71b67e60

Added: 
    

Modified: 
    clang-tools-extra/clangd/unittests/FindTargetTests.cpp

Removed: 
    


################################################################################
diff  --git a/clang-tools-extra/clangd/unittests/FindTargetTests.cpp b/clang-tools-extra/clangd/unittests/FindTargetTests.cpp
index c96b3a572322..408ebe24e773 100644
--- a/clang-tools-extra/clangd/unittests/FindTargetTests.cpp
+++ b/clang-tools-extra/clangd/unittests/FindTargetTests.cpp
@@ -770,10 +770,6 @@ TEST_F(FindExplicitReferencesTest, All) {
         "1: targets = {vector}\n"
         "2: targets = {x}\n"},
        // Handle UnresolvedLookupExpr.
-       // FIXME
-       // This case fails when expensive checks are enabled.
-       // Seems like the order of ns1::func and ns2::func isn't defined.
-       #ifndef EXPENSIVE_CHECKS
        {R"cpp(
             namespace ns1 { void func(char*); }
             namespace ns2 { void func(int*); }
@@ -787,7 +783,6 @@ TEST_F(FindExplicitReferencesTest, All) {
         )cpp",
         "0: targets = {ns1::func, ns2::func}\n"
         "1: targets = {t}\n"},
-        #endif
        // Handle UnresolvedMemberExpr.
        {R"cpp(
             struct X {


        


More information about the cfe-commits mailing list