[PATCH] D72378: [clang-tidy] Add `bugprone-reserved-identifier`

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman added a comment.

In D72378#1824586 <https://reviews.llvm.org/D72378#1824586>, @logan-5 wrote:

> Great! In that case, I'll need help committing this, as well as the thing it depends on, https://reviews.llvm.org/D72284 (which has also been LGTM'd).


Great, can you rebase this patch on master? It does not apply cleanly currently.

  c:\llvm-project>git apply C:\Users\aballman\Desktop\D72378.diff
  C:/Users/aballman/Desktop/D72378.diff:364: trailing whitespace.
  Checks for usages of identifiers reserved for use by the implementation.
  C:/Users/aballman/Desktop/D72378.diff:371: trailing whitespace.
  while the C++ standard strengthens this to reserve names with a double
  C:/Users/aballman/Desktop/D72378.diff:378: trailing whitespace.
    namespace NS {
  C:/Users/aballman/Desktop/D72378.diff:385: trailing whitespace.
  The check can also be inverted, i.e. it can be configured to flag any
  C:/Users/aballman/Desktop/D72378.diff:386: trailing whitespace.
  identifier that is _not_ a reserved identifier. This mode is for use by e.g.
  error: patch failed: clang-tools-extra/clang-tidy/utils/RenamerClangTidyCheck.cpp:271
  error: clang-tools-extra/clang-tidy/utils/RenamerClangTidyCheck.cpp: patch does not apply
  error: patch failed: clang-tools-extra/docs/ReleaseNotes.rst:94
  error: clang-tools-extra/docs/ReleaseNotes.rst: patch does not apply


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72378/new/

https://reviews.llvm.org/D72378