[PATCH] D72638: [clangd] Fix rename for explicit destructor calls

[Kirill Bobyrev via Phabricator via cfe-commits]

kbobyrev marked 3 inline comments as done.
kbobyrev added a comment.

The patch should probably be correct now.

I've submitted the issue I encountered while trying to add more tests for this patch since it seems to be a separate issue (hopefully, I'm doing everything correctly while setting up that test): https://github.com/clangd/clangd/issues/254.



================
Comment at: clang-tools-extra/clangd/unittests/FindTargetTests.cpp:900
+               $8^Foo $9^f;
+               int $10^fourtyTwo = $11^f.$12^operator int();
+               $13^f.~ /*...*/ $14^Foo();
----------------
`$12` would not be captured if we simply do

```
if (E->getMemberNameInfo().getNamedTypeInfo())
  return;
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72638/new/

https://reviews.llvm.org/D72638