[PATCH] D72326: [clang-format] Rebased on master: Add option to specify explicit config file
Thibault North via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Jan 16 08:47:45 PST 2020
tnorth updated this revision to Diff 238513.
tnorth added a comment.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Thanks for your time and feedback.
- Update diff with context,
- remove public declaration of LoadConfigFile,
- change prototype of LoadConfigFile and simplify it,
- avoid string copy to ConfigFile, use StringRef directly,
- don't stat the file before attempting to read it.
Regarding the tests, I am unsure how to do this currenlty (I'd need to read some docs/other examples).
I didn't have in mind the use case of BasedOnStyle: file:some/path.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72326/new/
https://reviews.llvm.org/D72326
Files:
include/clang/Format/Format.h
lib/Format/Format.cpp
unittests/Format/FormatTest.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D72326.238513.patch
Type: text/x-patch
Size: 5215 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20200116/1c42cc14/attachment-0001.bin>
More information about the cfe-commits
mailing list