[PATCH] D69585: PerformPendingInstatiations() already in the PCH
Luboš Luňák via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Jan 16 06:38:11 PST 2020
llunak updated this revision to Diff 238477.
llunak added a comment.
In D69585#1821831 <https://reviews.llvm.org/D69585#1821831>, @aganea wrote:
> What is the error?
I take that part back, actually. I don't quite remember anymore what exactly I did in October, but if I now revert the PCH tweaks in LibreOffice I did to avoid the error, the compilation fails even without the patch or with GCC. So I assume what really happened was that code changes triggered the error and I incorrectly assumed it was because of my patch. So, unless proven otherwise, I take it that my patch is actually technically correct without causing any code regressions (the OpenMP problem has just been fixed).
What remains is those 22 tests which fail because moving the instantiations reorders the code that is expected by FileCheck. This patch handles 2 of them, and it's already rather tedious (the OpenMP tests are large). Is this really the way to handle them, or does somebody have a better idea?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69585/new/
https://reviews.llvm.org/D69585
Files:
clang/lib/Sema/Sema.cpp
clang/lib/Sema/SemaTemplateInstantiateDecl.cpp
clang/test/CodeGenCXX/vla-lambda-capturing.cpp
clang/test/OpenMP/single_codegen.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D69585.238477.patch
Type: text/x-patch
Size: 13331 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20200116/d2eedb9a/attachment-0001.bin>
More information about the cfe-commits
mailing list