[PATCH] D72826: [clangd] Make output order of allTargetDecls deterministic
Sam McCall via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Jan 16 03:23:50 PST 2020
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
================
Comment at: clang-tools-extra/clangd/FindTarget.cpp:202
+private:
+ llvm::SmallDenseMap<const NamedDecl *, size_t> InsertionOrder;
llvm::SmallDenseMap<const NamedDecl *, RelSet> Decls;
----------------
why two maps vs map to pair<size_t, RelSet> here? Seems a little inefficient/untidy
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72826/new/
https://reviews.llvm.org/D72826
More information about the cfe-commits
mailing list