[PATCH] D50360: [Concepts] Requires Expressions

Saar Raz via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jan 15 13:29:08 PST 2020


saar.raz marked 4 inline comments as done.
saar.raz added a comment.

Addressed comments in latest diff.



================
Comment at: clang/include/clang/AST/RecursiveASTVisitor.h:2714-2716
+      if (RetReq.isTypeConstraint())
+        TRY_TO(TraverseTemplateParameterListHelper(
+                   RetReq.getTypeConstraintTemplateParameterList()));
----------------
rsmith wrote:
> We should traverse the entire //type-constraint// here, including the nested name specifier and concept name.
We are traversing all that down the line when traversing the actual template type parameter.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D50360/new/

https://reviews.llvm.org/D50360





More information about the cfe-commits mailing list