[PATCH] D72786: [clang] Set function attributes on SEH filter functions correctly.

Wed Jan 15 10:59:45 PST 2020

rnk added a comment.

Thanks, the code change looks good, but please adjust the tests a bit.

================
Comment at: clang/test/CodeGen/exceptions-seh-finally.c:284-286
-// Look for the absence of noinline. Enum attributes come first, so check that
-// a string attribute is the first to verify that no enum attributes are
-// present.
----------------
We shouldn't be marking this thing noinline. I believe it appears because clang applies noinline everywhere at O0. Please add `-O1 -disable-llvm-passes` to the RUN line so that it doesn't appear. The appearance of `nounwind` should be expected, so keep that here.

================
Comment at: clang/test/CodeGenCXX/exceptions-seh-filter-uwtable.cpp:1
+// RUN: %clang_cc1 "-triple" "arm64-windowsj" "-munwind-tables" "-fms-compatibility" -emit-llvm %s -o - | FileCheck %s
+
----------------
Is "arm64-windowsj" a typo? Also, please add `-O1 -disable-llvm-passes` as above.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72786/new/

https://reviews.llvm.org/D72786