[PATCH] D72401: Fixes for spaces around C# object initializers
MyDeveloperDay via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Jan 15 04:29:28 PST 2020
MyDeveloperDay added inline comments.
================
Comment at: clang/lib/Format/TokenAnnotator.cpp:2870
+ if (Left.is(TT_Unknown) && Right.is(tok::l_brace) && Left.Previous &&
+ Left.Previous->is(tok::kw_new))
+ return true;
----------------
krasimir wrote:
> The `TT_Unknown` is a bit confusing -- why is it needed? If this is a workaround for something, please add it as a comment. We might need to improve the token detection later to allow for more complicated pattern matching.
+1 that comment what was Left I think we need to be more specific
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72401/new/
https://reviews.llvm.org/D72401
More information about the cfe-commits
mailing list