[PATCH] D71199: [clang-tidy] New check cppcoreguidelines-prefer-initialization-list

[Eugene Zelenko via Phabricator via cfe-commits]

Eugene.Zelenko added inline comments.


================
Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/PreferMemberInitializerCheck.cpp:52
+static bool isUnaryExprOfLiteral(const Expr *E) {
+  if (const auto *UnOp = dyn_cast<UnaryOperator>(E)) {
+    return isLiteral(UnOp->getSubExpr());
----------------
Please elide braces.


================
Comment at: clang-tools-extra/docs/ReleaseNotes.rst:70
 
+- The 'readability-prefer-member-initializer' check was renamed to :doc:`cppcoreguidelines-prefer-member-initializer
+  <clang-tidy/checks/cppcoreguidelines-prefer-member-initializer>`
----------------
Is it relevant?


================
Comment at: clang-tools-extra/docs/ReleaseNotes.rst:73
+
+- The 'readability-prefer-initialization-list' check was renamed to :doc:`readability-prefer-member-initializer
+  <clang-tidy/checks/readability-prefer-member-initializer>`
----------------
Is it relevant?


================
Comment at: clang-tools-extra/docs/clang-tidy/checks/cppcoreguidelines-prefer-member-initializer.rst:15
+language version than `C++ 20`), furthermore the assigned value is a literal,
+negated literal or `enum` constant then the preferred place of the
+initialization is at the class member declaration.
----------------
Enum should be in double back-ticks as language construct.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71199/new/

https://reviews.llvm.org/D71199